×
Please submit new Bug Reports on GitHub: github.com/Jensen-Technologies/component-creator-issues/issues
1 month plan
Cedric
Yeni Üye
Posts: 4
9 yıl 8 ay önce #722
Yazan: Cedric
1 month plan, Cedric tarafından oluşturuldu
Hello,
First i like this tool, saved several hours.
I bought the one month support plan and I have 2 issues:
- where is the module builder?
- the generated code have a lot of problems, as sample the xml files, are totaly wrong generated (too many line breaks, line break missing, wrong alignement, ...), the php code is fine, but many probles, some times there is a line break before the { and some times not.... And indentation should be tab not, spaces...
- the file header comment should be a template.
This is a good tool, but not perfect, there is not many missing to become perfect.
Rick
First i like this tool, saved several hours.
I bought the one month support plan and I have 2 issues:
- where is the module builder?
- the generated code have a lot of problems, as sample the xml files, are totaly wrong generated (too many line breaks, line break missing, wrong alignement, ...), the php code is fine, but many probles, some times there is a line break before the { and some times not.... And indentation should be tab not, spaces...
- the file header comment should be a template.
This is a good tool, but not perfect, there is not many missing to become perfect.
Rick
Lütfen sohbete katılmak için Giriş ya da Hesap açın.
Cedric
Yeni Üye
Posts: 4
9 yıl 8 ay önce #725
Yazan: Cedric
Cedric tarafından 1 month plan konusunda yanıtlandı
?
$app = JFactory::getApplication();
$editId = JFactory::getApplication()->input->getInt('id', null, 'array');
should be:
$app = JFactory::getApplication();
$editId = $app->input->getInt('id', null, 'array');
$app = JFactory::getApplication();
$editId = JFactory::getApplication()->input->getInt('id', null, 'array');
should be:
$app = JFactory::getApplication();
$editId = $app->input->getInt('id', null, 'array');
Lütfen sohbete katılmak için Giriş ya da Hesap açın.
David Villena
Sorumlu
Posts: 6
9 yıl 8 ay önce - 9 yıl 8 ay önce #726
Yazan: David Villena
David Villena tarafından 1 month plan konusunda yanıtlandı
Hi Rick.
First of all, thank you very much for your feedback. Component Creator wouldn't be so awesome without the huge team of testers that you guys are
You're right about the code formatting; we're so focused on features, functionality and bug fixes that sometime we forget that code must look pretty and well-aligned for readability. We have a job on the queue to revise all the code generated and fix all format issues.
However, we can't agree about indentation: Joomla! coding standards , are based (with modifications) on PSR-2 Coding Style Guide , and there it is written:
2.4. Indenting
Code MUST use an indent of 4 spaces, and MUST NOT use tabs for indenting.
And we've solved the $app unused thing.
Best regards,
David.
First of all, thank you very much for your feedback. Component Creator wouldn't be so awesome without the huge team of testers that you guys are
You're right about the code formatting; we're so focused on features, functionality and bug fixes that sometime we forget that code must look pretty and well-aligned for readability. We have a job on the queue to revise all the code generated and fix all format issues.
However, we can't agree about indentation: Joomla! coding standards , are based (with modifications) on PSR-2 Coding Style Guide , and there it is written:
2.4. Indenting
Code MUST use an indent of 4 spaces, and MUST NOT use tabs for indenting.
About the Module Builder, on the Configuration view of your component you can find a checkbox with the label "Include Module" that, if checked, makes Component Creator to generate the structure of an empty module, that you can fill with the functionality that you need for it. Screenshot is attached.N.b.: Using only spaces, and not mixing spaces with tabs, helps to avoid problems with diffs, patches, history, and annotations. The use of spaces also makes it easy to insert fine-grained sub-indentation for inter-line alignment.
And we've solved the $app unused thing.
Best regards,
David.
Son Düzenleme: 9 yıl 8 ay önce Düzenleyen:David Villena
Lütfen sohbete katılmak için Giriş ya da Hesap açın.
Cedric
Yeni Üye
Posts: 4
9 yıl 8 ay önce #728
Yazan: Cedric
Cedric tarafından 1 month plan konusunda yanıtlandı
I am sorry, but
joomla.github.io/coding-standards/?codin.../basic-guidelines.md
Indenting is tab.
Rick
joomla.github.io/coding-standards/?codin.../basic-guidelines.md
Indenting is tab.
Rick
Lütfen sohbete katılmak için Giriş ya da Hesap açın.
David Villena
Sorumlu
Posts: 6
9 yıl 8 ay önce #733
Yazan: David Villena
David Villena tarafından 1 month plan konusunda yanıtlandı
Hi,
It appears that you're right, we'll change the indentation any time soon.
Regards,
David.
It appears that you're right, we'll change the indentation any time soon.
Regards,
David.
Lütfen sohbete katılmak için Giriş ya da Hesap açın.
Sayfa oluşturma süresi: 0.052 saniye